Responsive four card feature selection with additional layout
Design comparison
Solution retrospective
Hey community, could you please review my solution? I'm very interested in what can be improved visually and especially code-wise (I'm using BEM with minor class composition). Thank you!
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi relizard, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
As you know this project is based only on one page section, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an
h1
in this component, besides being a good practice for when you are developing larger sites, don't worry forget abouth1
.The rest is great!
I hope it helps... 👍
Marked as helpful0 - @a13g24Posted about 2 years ago
I recently implemented this design as well, and I really learned a lot from your implementation. Especially with the use of margin-block, something I was unfamiliar with until reading your code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord