Design comparison
SolutionDesign
Solution retrospective
I know I can improve the way I write my code, please if you have any advice I would greatly appreciate it. Thanks in advance for taking the time to see my solution and for leaving tips
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Luis! 👋
Congratulations on finishing this challenge! 👏Your solution is responsive and looks great! It's great that you write the styling with the mobile-first approach and use
em
unit for the breakpoint for the media query! 👍Some feedback.
- I highly suggest not changing the
html
font size because it can cause huge accessibility implications for those of the users with different font size or zoom requirements. So, I would recommend changing thebody
font size instead or even better setting the font size on themain
element (that wraps all the page content in this case). - I would suggest using
img
element rather than inline SVG to make the HTML looks cleaner. 😉
That's it! Hope you find this useful! 😁
Marked as helpful1@PazispeacePosted over 2 years ago@vanzasetia Thank you so much for the tips! highly appreciated
0 - I highly suggest not changing the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord