matbac85• 600
@matbac85
Posted
Hello !
Here's my feedback, but I should point out that I'm also learning, so I can't help you much.
I've also just finished this challenge and found it a bit tricky with the use of grids.
My solution is quite similar to yours, so I don't have much to say. I've organised my HTML differently (a header with the text above and a main with different sections for the cards). I saw that you'd added articles. I think that's good too.
What I've noticed, and what I've often been asked to correct, is the height in px and fixed. Apparently, it's better to avoid this. The same goes for element widths. The width property is deprecated.
Finally, for your media queries, you shouldn't use px, but rem.
Good job !
Marked as helpful
0
