Responsive Four card feature

Community feedback

• 

  C H A R A N 🎯•2,670

  @0xabdulPosted over 1 year ago

  Hello there well congrats on completing the four card features section 👍

  • In Html :
  • well your main landmarks are ok , but using the header tag like <h1><h2><h3><h4> this in line by line or sequence way
  • Ex :

  <h1>Reliable, efficient delivery</h1>
  <h2>Powered by Technology</h2>
  <h3>Our Artificial Intelligence powered tools use millions of project data points to ensure that your project is successful</h3>
  

  • I Hope it's useful for you
  • Happy Coding

  0

  ---

  

  nooshin bakhtiari•110

  @itsnooshinPosted over 1 year ago

  @0xAbdul Thank you for the feedback. I just learned about BEM, and because you believe it's important, I'm wondering if all of my code is correct?

  0

  

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  @0xAbdul

  Headings should not be mistaken for font-sizes.

  <h1>Reliable, efficient delivery</h1> <h2>Powered by Technology</h2> <h3>Our Artificial Intelligence powered tools use millions of project data points to ensure that your project is successful</h3>

  Here this is not correct. First two lines are a single unit of a header. So it must be like:

  <h1>Reliable, efficient delivery <br/> Powered by Technology</h1>

  and text below is not a h3, but a descriptive paragraph so it should be wrapped in <p> and not <h3>

  1

  

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  @itsnooshin Good work there with responsiveness! My suggestion would be to add some max-width for the grid items or simply to grid container itself to prevent them get too wide on larger screen.

  Hope you find this feedback helpful!

  0