Responsive for two devices using the tailwind component for header.
Design comparison
Solution retrospective
Feel free to provide your opinion about my code and your opinion is what I'm looking for. I found the most difficult part of this challenge is to make the landing page responsive. It took a lot of time to partially finish it. So I appreciate the feedback.
Community feedback
- @OkaforRaphPosted over 2 years ago
Hey @ Satya, Congratulations on completing the challenge š.
Here are some tips to help you on your next project..
-
First, there are issues with accesibility and HTML issues from your code which should be looked at.
-
Secondly, the arrow on your hero section is not there (From the preview).
-
Also, your code is not linked properly (I think you linked the wrong GitHub repository) so I can see your code to correct you further.
Hope this helps, Happy Coding š
Marked as helpful1@satya-hashPosted over 2 years ago@OkaforRaph First of all thanks for feedback. This make me so happy. I removed the arrow key on purpose. As iam a beginner, I don't know clearly what is accessibility issues are ? So I will try my best to understand and improve my skills. And i updated the GitHub repository.
0 -
- @Prakhar-99Posted over 2 years ago
hello @satya-hash here some advise that I think make your sollution quite good 1 add background-repeat = no-repeat and background-position = center, background size = cover in all your background container. 2.when you apply media query change the flex direction of container that contain egg background image . 3 add margin from left, right in content (h1, paragraph and button) of class " left & right". and give some specific width to para of this classes. 4 give specific width to para of classes orange and cherry like 80%-85%.
5.give a margin top and bottom in your testimonial section and give a width of 300 or 320px to your testimonia card and on flex wrap in testimonial card container thanks for read hope this can help you make your solution good
Marked as helpful0@satya-hashPosted over 2 years ago@Prakhar-99 Thanks for valuable information that you provided to me and I will try my best to follow the instructions and also correct my mistakes. If you have any free time can you inform me about the "HTML" issues and "ACCESEBILITY" issues.
0@Prakhar-99Posted over 2 years ago@satya-hash ok brother I try when I have free time tommarow
Marked as helpful0@Prakhar-99Posted over 2 years ago@satya-hash brother put all your meta, link, inside head tag and all other code inside body tag
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord