Responsive for mobile and desktop (screen sizes 375px and 1440px).

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by wrapping the whole content with semantic element <main> along with <div class="attribution"> the with semantic element <footer> in your index.html file to improves accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  ID 💢:

  • The id attribute uniquely identifies elements on a page. It does not make sense to duplicate an id.

  ---

  • Duplicate id's can break the accessibility of labels for forms, table header cells, etc., by the second instance being skipped by screen readers

  ---

  • They are common markup validation errors that can eliminate possible sources of accessibility problems, when not breaking accessibility.

  ---

  • So kindly give unique names for id attributes

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Bruno•260

  @BrunoSousaWDPosted over 1 year ago

  @0xAbdulKhalid thanks for taking the time to explain it the way you did, I really appreciate it. It will be fixing it ASP. Cheers

  0