Responsive flexbox mobile first, HTML , CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 4 years ago

  Nice work

  A few bits don't quite match the design (left aligned heading text, background gradient, cards hitting side of screen on mobile) but the code and outcome looks good.

  Very very minor points would be:

  • I don't think you can max width html. If you want to apply a max width do it lower down the dom, like on a main layout wrapper where you could also margin auto the sides.
  • card-images don't need filled in alt attributes. That alt text isn't adding anything, so just leave the alt attribute intentionally blank so assistive tech knows those images are decorative.

  All good otherwise! Really nice semantically structured html and easy to understand css 👍 👍 👍

  Next step is to learn/try css grid, which would allow you to remove the additional 'column' wrappers you've had to add to make this work in flexbox.

  1

  ---

  

  P

  Dexter Dick•185

  @DexterDickPosted about 4 years ago

  @grace-snow Thank you Grace I made some of the changes recommended. Thank you for your help.

  1