Design comparison
Solution retrospective
-Aligning the image to center was a challange -Was the use of .root in css neccsary -I was able to learn using from the guild -The use of flex was very helpful to set the div in columns -How more can I continue to develop best in html and css
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @iOtele!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>
to wrap the main content instead of<div>
.
๐ Tags like
<div>
and<span>
are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - Use
- @hassanmoaaPosted 10 months ago
Hello @iOtele!
Great Job solving the challenge mate congrats ๐
Some suggestions for improvements.
For the font-size it's is better to use rems and ems but px for this project is no big deal.
font-size: 13px;
-
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
-
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
โโโโโโโโ
Use <main> to wrap the main content instead of <div>. * ๐ Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
โโโโโโโ
You canโt put text in plain divs or without an semantic tag:
Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.
<h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>Other than that you're good, keep up the good work!
Marked as helpful0 -
- @petritnurediniPosted 10 months ago
Congratulations on completing your Blog Preview Card project! It's an excellent achievement, and I'm thrilled to see your dedication to developing your front-end skills. Here are a few recommendations for improvements:
-
Semantic HTML Tags:
- Consider using more semantic HTML tags to enhance the accessibility and structure of your code. For example, you could use
<article>
for the main content area and<footer>
for the bottom attribution section. This not only makes your HTML more readable but also helps with SEO and accessibility. Learn more about semantic HTML here.
- Consider using more semantic HTML tags to enhance the accessibility and structure of your code. For example, you could use
-
Alternative Text for Images:
- It's important to provide alternative text for images using the
alt
attribute. This is crucial for users who rely on screen readers. For instance,<img src="assets\images\image-avatar.webp" alt="Greg Hooper's avatar" />
provides more context. Read about the importance of alt text here.
- It's important to provide alternative text for images using the
-
CSS File Naming:
- The naming of your CSS file as
index.css
might be a bit generic. Consider renaming it to something more descriptive, likeblog-preview-card.css
. This helps in maintaining and understanding the purpose of the stylesheet, especially in larger projects.
- The naming of your CSS file as
Keep pushing the boundaries and exploring new challenges in web development. Your progress is impressive, and each project takes you one step closer to mastery. Keep up the great work and happy coding! ๐๐จโ๐ป
Marked as helpful0@iOtelePosted 10 months agoThank you so much. Iโm considering points made. @petritnuredini
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord