Responsive FAQ

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Front-end Master! 👋

  Nice to see you complete another challenge! Good work on this one! 👍

  I like the animation you added to the floating cube (I happened to have the same idea when I completed this challenge, LOL 😆) and how you animated the entire hero image in the mobile layout, too! Using a description list for the FAQs was a good idea, too, I think. 😉

  Keep coding (and happy coding, too)! 😁

  1
• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi Alexsandr,

  I think maybe you meant to use details and summary for your accordions? Details lists are for key-value pairs of statistics - think things like stats about a product. Details list content is almost like tabular data that only has one header cell and one content cell per row. Other benefit if you used details and summary is you get accordion functionality for free with no javascript required.

  Usually accordion functionality should allow people to open more than one item at a time too. Expected behaviour for tabs is to show one thing at a time, but for accordions there is not me at to be such a restriction. Its an accepted UI pattern to be able to expand multiple accordion items.

  Solution looks a nice design overall, and close to the original.

  Is your bg height limited? I'm seeing a line at the bottom on mobile, where it looks like the background starts to repeat. I'll add a screenshot to slack for you so you can see what I'm seeong

  Hope thats helpful feedback ☺

  0