Responsive FAQ accordion using jQuery

Community feedback

• 

  Saul Gabriel Aranguren•320

  @saularangurenPosted 6 months ago

  Greetings Ren, your solution is really interesting and wonderful, however, it can be improved in the organization of files and folders, within your index.html file you should not do this:

  <link
        rel="icon"
        type="image/png"
        sizes="32x32"
        href="./assets/images/favicon-32x32.png"
  />
  

  better do this:

  <link rel="icon" type="image/png" sizes="32x32" href="./assets/images/favicon-32x32.png"/>
  

  Don't cut the lines, doing that is bad practice and messes up your code.

  correct this bad practice in all the lines where it is repeated, upload your changes again to your gthub repo

  In addition to that, I recommend learning Sass, it will help you create CSS styles ordered and by modules, this way you will not have a style sheet with more than 500 lines

  ---

  Links:

  ---

  1. Sass course in Spanish

  2. Sass course in English

  3. Sass official documentation

  4. Example of how to work with sass, what you can do and have an idea of working with sass

  happy code development

  Marked as helpful

  0

  ---

  

  ren•50

  @ktmagnoPosted 6 months ago

  thank you @saularanguren I'm using an extension called 'Prettier' in VS Code that's why my code is like that. I really want to learn Sass too, maybe I should try it on my next challenge. Just a quick question tho, how do you get your solution 100% accurate with the design? That's so amazing! 👏🏼

  1

  

  Saul Gabriel Aranguren•320

  @saularangurenPosted 6 months ago

  @ktmagno Greetings friend, to obtain the precise solution, you must see the figma file that is delivered in the challenges, if you have a free account you can only obtain the figma file of the free+ challenges and to obtain the figma file of all the challenges and including challenges of first quality you must buy an annual or monthly subscription to frontendmentor, when you pressed the button to complete the qr code card challenge, it appeared next to it, download figma file or sketch, you simply download the figma file and run it in the program or website figma, you need to create an account, it's free, I recommend watching YouTube videos on how you can use that tool, happy coding

  Marked as helpful

  0

  

  ren•50

  @ktmagnoPosted 6 months ago

  i see.. thanks @saularanguren! 😊

  1
• 

  P

  Koda👹•3,830

  @kodan96Posted 6 months ago

  hi there! 👋👋

  Instead of giving the image position: fixed set it as the background-image to the body element like this:

  body {
  background-image: url()
  background-size: contain;
  background-repeat: no-repeat;
  }
  

  just copy the img path into url() this should resolve the issue.

  Hope this was helpful! 🙏

  Good luck and happy coding! 💪

  Marked as helpful

  0

  ---

  

  ren•50

  @ktmagnoPosted 6 months ago

  got it! thank you so much @kodan96 😊

  1