Responsive faq accordion using grid & flexbox

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi there! 👋

  Good effort on this challenge! Your solution is responsive and looks great! 👍 It's great that there's a functionality where you only allow the user to open one accordion panel at a time. Well done! 👏

  There are two things that can be done better.

  • Firstly, I would recommend using the native HTML element to create the accordion, details and summary. They are pronounced correctly by the screen readers by default.
  • Secondly, I would suggest removing the console.log from the script.js.

  Overall. great work! All the images are decorative and you have done the right thing by leaving the alt empty. The only major problem is the accordion that is not accessible by the screen reader users.

  So, I hope this helps! Keep up the good work! 👍

  Marked as helpful

  0

  ---

  

  ccbdp•315

  @ccbdpPosted over 2 years ago

  @vanzasetia thank you for your comment! Figured i'm a little weak with regards to accessibility and I hope to work on that, thank you again for the advise!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @ccbdp You're welcome! 👍

  0