@shashreesamuel
Posted
Hey nonamehz, good job completing this challenge. Keep up the good work.
Your solution looks good however the sentence "What is the maximum file upload size" should be in bold.
I hope this helps
Cheers Happy coding š
My first challenge with JS :]
@shashreesamuel
Posted
Hey nonamehz, good job completing this challenge. Keep up the good work.
Your solution looks good however the sentence "What is the maximum file upload size" should be in bold.
I hope this helps
Cheers Happy coding š
@vanzasetia
Posted
Hi, Jose! š
Congratulations on completing your first JavaScript challenge! š
Some feedback on this solution:
main
landmark! šheader
for the card content since it is not a full webpage. This is one chunk of content that all belong together and in a real website would sit with other content.details
and summary
. They are accessible by default.:focus-visible
styling to any interactive elements (button
, links, input
, textarea
). This will make the users can navigate this website using keyboard (by using Tab
key) easily.img
tag should have empty alt=""
and aria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only.rem
or sometimes em
unit instead of px
. Using px
will not allow the users to control the size of the page based on their needs.body
element, it will not allow the users to scroll the page if the page content needs more height
. Use min-height
instead.width: 100vw
to the .container
element. By default, the block element would have full width. Also, remove the overflow: auto;
.body
element as the flex container to center the .container
or the card in the middle of the page. That way, I can remove the section
tag inside the .container
since it's neither adding meaning nor making the HTML more semantic.1440px for desktop layout is too late. It looks like you are using the value from the style-guide.md
as your breakpoint. The sizes on the style-guide.md
have nothing to do with the media queries. They are telling you that "this is how your website should look like at these screen sizes". As frontend developers, we should keep making your website looks good in between those screen sizes.
That's it! Hope you find this useful! š
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord