Design comparison
SolutionDesign
Solution retrospective
It's my first time writing Javascript and doing DOM Manipulation, I don't know if I did good :)) If you notice that I did bad practices in my code, I'll appreciate it f you point it out to me :))) Thank you!!!
Community feedback
- @RevazSologhashviliPosted 11 months ago
You did great job.
I noticed two thing you can improve here.
- Try to close already opened question if you open another.
- There is extra height on screen. you can use
body{min-height: 100dvh;}
this will set minimum height based on device screens sizes so there will be no more unnecessary scrolling
Marked as helpful2@ZaiBermPosted 11 months ago@RevazSologhashvili Thank you for your feedback, I will try to improve my work :))
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord