Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive FAQ Accordion

ZaiBerm 50

@ZaiBerm

Desktop design screenshot for the FAQ accordion coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It's my first time writing Javascript and doing DOM Manipulation, I don't know if I did good :)) If you notice that I did bad practices in my code, I'll appreciate it f you point it out to me :))) Thank you!!!

Community feedback

P

@RevazSologhashvili

Posted

You did great job.

I noticed two thing you can improve here.

  1. Try to close already opened question if you open another.
  2. There is extra height on screen. you can use body{min-height: 100dvh;}

this will set minimum height based on device screens sizes so there will be no more unnecessary scrolling

Marked as helpful

2

ZaiBerm 50

@ZaiBerm

Posted

@RevazSologhashvili Thank you for your feedback, I will try to improve my work :))

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord