Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive FAQ Accordion

Jyoti Bhandariā€¢ 210

@Jyoti-Bhandari

Desktop design screenshot for the FAQ accordion coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What specific areas of your project would you like help with?

Open for any kind of feedbacks :)

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @Jyoti-Bhandari!

Your solution looks great!

I have a suggestion for improvement:

šŸ“Œ Think about using <main> to wrap your main content instead of <div>.

Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

Hope that's helpful!

Keep up the great work!

Marked as helpful

0

Jyoti Bhandariā€¢ 210

@Jyoti-Bhandari

Posted

@danielmrz-dev okay sir. I will try to do use main tag more often. Thanks for your feedback :)

1
Ekin Sipahiā€¢ 250

@ekinsipahi

Posted

absolute positioning would be better here because in lg the card is not partially overflowing the faq section but this is acceptable and good. check out my solution if you want.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord