Responsive Expense Chart w/User data input feature
Design comparison
Solution retrospective
Please have a look at my react code and let me know if I commited any "best practice" faux pas!
Community feedback
- @mksoofianPosted over 1 year ago
Hey Thanh,
I really love your accuracy with your aspect ratio. I did not take the time to look through your code as I am not familiar with Vite but I wanted to note that Solution provided is not very responsive. The bars become squished and the component becomes cut off from view as the viewport shrinks. I would recommend improving this so that your component can be viewed on devices of almost any size.
Enjoy!
Mike
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>
element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
- The
- So resolve the issue by replacing the react's root node
<div id="root">
with the proper semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord