Responsive E-commerce-sneaker-page built with ReactJS and MUI

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution lacks usage of <h1> so it can cause severe accessibility errors due to lack of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">E-commerce product page</h1>

  ---

  • If you have any questions or need further clarification, you can always check out my submission for another challenge where i used this technique and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Gautam kumar•200

  @GautambudhPosted over 1 year ago

  @0xAbdulKhalid thanks for your suggestion. I will implement it

  0
• 

  Paolo Vilardi•160

  @PaoloVilardiPosted over 1 year ago

  It appears as a great solution, congrats! The only thing I can say is that adding products already in the cart don't update the cart by adding the quantities but by replacing them. It needs just a little trick in the javascript: just check if the element is already in the cart, if this is true take the quantity stored in the item and update it, both in the logic and in the html for the icon on the cart and for the item inside the cart. Remember to update the total price too. But it's just a really small thing. Congrats again for your amazing solution!

  0

  ---

  

  Gautam kumar•200

  @GautambudhPosted over 1 year ago

  @PaoloVilardi the quantities of product is only added to the cart when Add to cart button is clicked. Since we have just one product example , I didn't laid much emphasis on logic going inside the cart. Although I had considered this too. And thanks for your suggestion, I appreciate it.

  0