Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive ecommerce website using mobile first

Nicolas 90

@byNico1

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am practicing my frontend skills I would like feedback on:

how can I improve my javascript code? because I think it could be improved but without a framework just vanilla JS as I did it

Community feedback

@JBlezi

Posted

Hey Nicolas, looks really great! Love the rounded edges and the overall subtle but effective styles. Shopping cart also works flawlessly. The only little thing I noticed is that when you hover on the profile pic, the border of the avatar is pushing the shopping cart icon to the side. You can easily fix this by deleting the content-box property from your avatar:

.avatar:hover { /* box-sizing: content-box; */ <-- DELETE THIS border: 3px solid var(--orange); border-radius: 50%; }

Hope this helps :)

Marked as helpful

0

Nicolas 90

@byNico1

Posted

@JBlezi thanks, I will change that

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord