Design comparison
Solution retrospective
Feedback is much appreciated , still learning react had some issues with the context I made the state keeps making infinite loops. I made the slider and the navbar into to components one for mobile and the other for desktop, so is this a good way or there is a a better one?
Community feedback
- @JunasVeePosted over 2 years ago
Hi Hussin!
Your page is responsive and it looks good to me, I can't really mention all of the issues since you said you're still learning reactjs which I think it's common to have difficulties functionalizing particular things. But here are the issues that are such a "big deal" in my personal opinion:
-
The cart, it's one of the main concepts in this challenge. In Ecommerce Product design, having a cart like this makes the customers know what they have been putting on. I saw that you have set the function for it but it doesn't seem working on my device, please let me know if it actually works.
-
Increment and Decrement, I tried to decrease the number when it's 0. it's good that the output doesn't show a negative number, but if you click it 3 times after 0, in order to put it back to 0 it also takes 3 increment clicks, so behind the scene, it is still a negative value without showing it to the output. So instead of creating a string for negative values, when counter <= 0 set its value to 0 too.
I hope my feedback is helpful.
Marked as helpful1@HussinSoliPosted over 2 years ago@JunasVee thank you for the advice it is very helpful ^^ the cart works for me you set the count and click add to cart it adds the item. I will work on improving the Increment and Decrement functionality to make the changes provided by you thanks again :)
1@JunasVeePosted over 2 years ago@HussinSoli I see, so it's added after the amount is set. That's great, my bad.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord