Responsive Ecommerce Product Page using React

Community feedback

• 

  Michael Bishop•1,080

  @MikeBish13Posted over 2 years ago

  Great job on this project - everything seems to be working well.

  Couple of things I've spotted in terms of how you've built your React app:

  • It's best practice to not use DOM selectors when using React (eg document.getElementByID), as this defeats the purpose -- React was designed so that you wouldn't need to access the DOM directly and that it could be manipulated based on state. For example, in order to make your cart visible, you could create a local bit of state cartIsVisible which could either be true or false, then create a CSS class for the cart isVisible, which would have the property of display: block, then put a conditional statement in your cart's className, eg className={cartIsVisible ? 'cart isVisible' : 'cart'} so that every time cartIsVisible is changed, the display property would also change.

  • Secondly, you should also try not to have onClick and 'onChange' functions written out fully within your JSX -- it can get quite messy and is difficult to understand. Instead, create a name for the function and write it out above the JSX, then reference it below.

  Hope that all helps!

  Marked as helpful

  0