Responsive Design with SCSS, Semantic HTML, and CSS Grid

Community feedback

• 

  Francisco•210

  @antoniomontoiaPosted about 1 month ago

  Yes, the project closely resembles the original design! However, I noticed a couple of areas for improvement:

  The <h1> and <h2> elements appear larger in the original design. While the design instructions do not specify whether the fonts should be fully responsive, it would be beneficial to ensure they match the intended sizes more closely.

  Additionally, you should have tested the design for responsiveness down to 320px width. By fixing the card width to 380px, the cards do not adapt well to smaller screen sizes, which affects overall responsiveness.

  Overall, accessibility is well considered, but there are a few areas for improvement:

  The header structure is not entirely correct; the <h1> should always come first, even if it does not visually appear to be the most important piece of information. It would also be helpful to provide more descriptive alt text for the image elements to enhance accessibility for users relying on screen readers.

  Marked as helpful

  0