Responsive design with help of CSS Grid + BEM

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi there! 👋

  Your solution is responsive and looks great! 👍

  Some suggestions from me.

  • Avoid using header and article for the card content since it is not a complete website. This is one chunk of content that all belong together and in a real website would sit with other content. So, I recommend wrapping each section with div instead.
  • For the "Why us" section, I would recommend making it as a list of items instead of using paragraph elements. If the site has no styling then it would more likely be a list.
  • I don't recommend changing the html or the :root font size. It can cause huge accessibility implications for those users with different font sizes or zoom requirements. I suggest reading this article by Josh Comeau where he tells about the problem of the 62.5% trick (and more!). Also, I recommend reading what an accessibility expert (Grace Snow) has said about it.

  That's it! Hope this helps. 😊

  1

  ---

  

  Vikram Ingleshwar•280

  @vikramviPosted over 2 years ago

  @vanzasetia Thanks a ton for review and comments, I'll read more about them and fix it.

  Regards, Vikram

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @vikramvi No problem! 👍

  0