Design comparison
Community feedback
- @natashaplPosted about 2 years ago
Hi Dave! Congrats on uploading your first solution and welcome to Frontend Mentor! Also, nice work on your solution! If you'd like to get rid of the accessibility issues that's in your report, consider changing the
<div class="container">
to<main class="container">
. I also suggest changing<div class="attribution">
to `<footer class="attribution">. These HTML 5 tags help improve accessibility for screen readers. Here's an article that discusses the benefits of semantic tags:HTML5 Semantic Tags: What They Are and How to Use Them!
I hope this is helpful. :)
Marked as helpful1@DaveAigbePosted about 2 years ago@natashapl Thank you so much, when I was actually going through it I couldn't figure out which semantic tags to use that made sense, so I ended up just giving them divs that made sense. This brings a lot of clarity to other things I have been working on that don't deal with a lot of text, so I really appreciate the feedback!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord