responsive design white html cssflexbox and bootstrap

Community feedback

• 

  Lê Hoàng Long•290

  @JamesWallison1Posted 6 months ago

  Seeing that you have made a lot of progress! Congratulation on completing one of the FEM challenges! Really impressive. You solution is fine but need some adjustments and I hope you will take those into account!

  • First, one of the main problem that almost all beginners may get in is not using landmarks. Here in your code, I am seeing that you are using div as a class to store your code but those divs can not describe what is the role of that part. So you can consider using <section></section> <footer></footer> to replace those!
  • Next one this is a minor mistake, but you can also consider fixing, is that: it is recommended to use arial font, instead you can use the provided fonts for the equality to the design but this is up to you, I mean if you want to keep your styles, then just keep it, there is no rules to maintain the provided fonts.
  • Thirdly is important, remember this is a container event not a landing page so adding padding and the width to the container is also important. Your code here is not minimizing the container yet leading to the "landing page" exercise so consider adding those!
  • There are also some small mistakes with alt of img so consider adding those.

  And you're good to go! I have to admit your solution is really good so keep pushing yourself to become a successful developer! Thanks a lot for spending time reading this small comment!

  0