Responsive design using Flexbox

Community feedback

• 

  BasemAmr•120

  @BasemAmrPosted almost 3 years ago

  Greetings, Oscar Your work is really great, there are only small notes to come over the accessibility problems. I think that it means by "missing landmarks" is to use semantic HTML, your card "div" should be created as a "main" element. attribution div should be created as a "footer" element. Also, the hero illustration "alt" text should be assigned to a value not an empty string, you can call it, for example, Hero. Best of luck, and keep up awesome work

  Marked as helpful

  0

  ---

  

  Oscar Carvajal•120

  @ocarmoraPosted almost 3 years ago

  @BasemAmr You are right on everything that you comment. Y will include semantic HTML tags on my next try! Thank you a lot for your feedback!

  0
• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Congrats on completing the challenge, @oscarvajalmora

  Your solution looks really good. I have just a few suggestions that I hope will be useful to you:

  • Decrease the size of the card a bit

  • Do some tweaks for responsive for mobile screen

  • Add box-shadow to the card

  Hope these tips will be useful. Keep up the great work!

  0

  ---

  

  Oscar Carvajal•120

  @ocarmoraPosted almost 3 years ago

  @Remus432 Thanks for your comment! I will do my best for the next try!

  0