Responsive design using HTML5 & CSS3 (Flexbox)

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  In your html, get everything into meaningful elements. Those stats should be in a list of 3 items.

  Your class names are a bit strange/confusing in format. Maybe read up on naming conventions like BEM to see if that helps you

  In css, you shouldn’t need to put explicit heights on things. That’s a bad practice to get into - what if an editor adds more text or a user zooms their font size. Let elements grow by using min- instead (if a height is needed at all)

  When using flexbox, you’ll get more responsive results by using flex properties like -basis on the flex children instead of widths. Not essential but worth trying

  Last thing - I’m seeing desktop view on my mobile landscape. Probably because everything’s so small(?)

  Good luck

  1

  ---

  

  Heli0s•670

  @zeerobitPosted over 3 years ago

  @grace-snow will implement your feedback.. thank you

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  This is all teeny tiny so I can’t read it (viewing on mobile)

  1
• 

  Smita•395

  @Smita-14Posted over 3 years ago

  Your website shows mobile screen size even on the desktop screen size.

  0

  ---

  

  Heli0s•670

  @zeerobitPosted over 3 years ago

  @Smita-14 just noticed it.. fixed it . Thanks

  1

  

  Smita•395

  @Smita-14Posted over 3 years ago

  @Dblack84 The image color doesn't match perfectly but the rest is brilliant. You've done a pretty good job!

  0

  

  Heli0s•670

  @zeerobitPosted over 3 years ago

  @Smita-14 will work on the color filter for a closer match.. thanks

  1