@Miguelaeb
Posted
Hi @erickvl, congratulations on your solution!
Great solution and a great start! From what I saw you're on the right track. I've a few suggestions for you that you can consider adding to your code:
Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the link below where you can download this file which contains the normalize.css: https:/ /necolas.github.io/normalize.css/
You should take a look at the style guide that they put on the files, there are specific styles and fit sizes that you have to use.
Also, I recommend you to create a new file for the styles and intend of having it with the HTML all together.
Add a margin of around 20px to avoid the card touching the screen edges while it scales down.
Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better for making your website more accessible. REM does not just apply to font size, but to all sizes.
Here's my solution for this challenge if you want to see how I build it: https://www.frontendmentor.io/challenges/qr-code-component-iux_sIO_H/hub/qr-code-component-UGmSDEakFi
I hope this helps you and happy coding!
@erickvl
Posted
@Miguelaeb thank you for the great feedback!
Unfortunately, I can't view your solution, it say's it's not mine.
