Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHello Ryan, congratulations for your first solution! ๐ Welcome to the Frontend Mentor Coding Community!
๐ Great start and great first solution! Youโve done really good work here putting everything together, Iโve some suggestions you can consider applying to your code:
Your image is not displaying doing a import error. Note that if you're using the folder locally the live server recognizes the image location, but with a live solution you need to indicate where the image is. Remember, when the image is inside the repository folder use dot slash
./
and if is inside a subfolder use dot dot slash../
If the image is the same folder of the html without folder just add normal path.Here's the correct import:
<img src="./images/image-qr-code.png" alt="" class="image">
Replace the
div
with<main>
(every page should have a main landmark and also a main h1 heading) so replace the h3 to with<h1>
and follow the sequence if you add another heading as h1, h2, h3โฆ Add a margin of aroundmargin: 20px
to avoid the card touching the screen edges while it scales down.โ๏ธ I hope this helps you and happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord