Responsive design using BEM and SASS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Thibault! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Great work on this one! Your solution looks good and is responsive! 👍

  I only suggest making sure the bottom background image always sticks to the bottom of the screen (even on larger screens), which you can easily do by adding min-height: 100vh to the body. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Thibault•205

  @thibault-barratPosted almost 4 years ago

  @ApplePieGiraffe You're right, I updated the code and it's better like this. Thank you :)

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Congratulations @Thibault. Your solution is really crisp. Fully responsive and clean. You used BEM and I love it. One suggestion, you used 5 img tags to draw stars, but what if you want to draw 4.2 or 4.5? I suggest you to use background-image and background-repeat properties to draw stars and set width to show 4.5 or 4.2. Hope it helps. Happy coding~ :)

  1

  ---

  

  Thibault•205

  @thibault-barratPosted almost 4 years ago

  @MasterDev333 Thank you ! Smart idea to use background-image to display stars. I modified the code accordingly.

  0
• 

  Guilherme dos Anjos•35

  @guilhermek1Posted almost 4 years ago

  Is there any way to do the same using only css flexbox? Or do I necessarily use sass in ordor to make this responsive?

  0

  ---

  

  Thibault•205

  @thibault-barratPosted almost 4 years ago

  @guilhermek1 I actually used flexbox to make it responsive. Sass is only a CSS preprocessor, it helps to generate nice stylesheet but it doesn't really help to make a design responsive.

  0
• 

  kevin•80

  @kevocamPosted almost 4 years ago

  nice!! congratulations

  0

  ---

  

  Thibault•205

  @thibault-barratPosted almost 4 years ago

  @kevocam Thanks :)

  0