responsive design of a qr code card

Community feedback

• 

  Ashley waudby•270

  @00awaudbyPosted almost 3 years ago

  thankyou for the feed back i saw my mistakes , i have adjusted it now cheers .

  0
• 

  Aditya Singh•460

  @adityas24Posted almost 3 years ago

  Hey Ashley you did a great job!🙂

  I studied your code well and found some points you need to improve on: 🙂

  1. You are using div element where it is not necessary. Using div there will not create any problem, but you are unnecessarily increasing the length of the code. That will reduce the maintainablity and readability of the code.

  For example: <div class="header"> <h1>Improve your front-end skills by building projects</h1> </div>.

  Here you do not need to wrap h1 in a div. If still you want to write h1 inside of a header, then use <header> tag instead. As we have to take care of semantics also 🙂

  2. Similary you don't need to wrap paragraph inside of a div. You can straight away use <p> tag without wrapping it. Afterall everything inside a flexbox will become flex item. You don't need to wrap everything inside a div 🙂

  I will recommend you to go through markup written by Daniel. He has written it perfectly i think

  https://www.frontendmentor.io/solutions/qr-code-component-using-html-and-css-38XEjHXG2

  All the best 🙂👍

  0