Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive design implemented using grid and flex box

@iamurmani

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Implemented using grid and flex box. Fell free to give feedback which will help me to improve.

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi, Manigandan! 👋

Nice work on this challenge! 👍

Some feedback to improve this solution.

  • Don't limit the height of the body element, it will not allow the users to scroll the page if the page content needs more height. Use min-height instead. Also, there's no need to specify width: 100% for the body element because by default it already has 100% of the width.
  • The Sign-up button should be a link element. I would expect it will navigate me to the Sign-up page after I click the button. Regardless, I would recommend always specifying the type of the button to prevent it from behaving unexpectedly.
  • The text below the "Why Us" should be a list. In my opinion, it much more makes sense if it is read as a list instead of as a sentence. Also, if the site has no styling, a list element would be a good fit.
    • Tutorials by industry experts
    • Peer & expert code review
    • Coding exercises
    • etc...

I hope this helps!

Marked as helpful

1

@iamurmani

Posted

@vanzasetia Thank you for the feedback. Thanks a lot for explaining the body height i was really confused about it now i got better understanding.

0
Vanza Setia 27,795

@vanzasetia

Posted

@iamurmani You're welcome! Glad that it helped you! 😄

0

@Kamasah-Dickson

Posted

Your solution looks great but on smaller screens your card dont have enough width, reduce the margin left and right on smaller devices.

Besides good job there👍 Happy coding👍

Marked as helpful

1

@iamurmani

Posted

@Kamasah-Dickson Thank you for the feedback will do the changes.

0

@Kamasah-Dickson

Posted

@iamurmani you are always welcome👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord