@vanzasetia
Posted
Hi, Manigandan! 👋
Nice work on this challenge! 👍
Some feedback to improve this solution.
- Don't limit the height of the
body
element, it will not allow the users to scroll the page if the page content needs moreheight
. Usemin-height
instead. Also, there's no need to specifywidth: 100%
for thebody
element because by default it already has 100% of the width. - The Sign-up button should be a link element. I would expect it will navigate me to the Sign-up page after I click the button. Regardless, I would recommend always specifying the
type
of thebutton
to prevent it from behaving unexpectedly. - The text below the "Why Us" should be a list. In my opinion, it much more makes sense if it is read as a list instead of as a sentence. Also, if the site has no styling, a list element would be a good fit.
- Tutorials by industry experts
- Peer & expert code review
- Coding exercises
- etc...
I hope this helps!
Marked as helpful
@iamurmani
Posted
@vanzasetia Thank you for the feedback. Thanks a lot for explaining the body height i was really confused about it now i got better understanding.
@vanzasetia
Posted
@iamurmani You're welcome! Glad that it helped you! 😄