Responsive design (HTML/CSS), slider on click and arrow keys (JS)

Community feedback

• 

  Guillaume Fontorbe•145

  @gfontorbePosted over 3 years ago

  Good use of semantics is still not engraved in my brain. I read about it more and more but for some reason, I keep using generic divs... I guess I'm still focusing too much on reproducing the design.

  I had a default content, removed it for testing, didn't put it back...

  I'll have a look at others' solutions for the labeling of images.

  As always, very useful comments and tips!

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Really important to use semantic html. I can't stress it enough.

  And use interactive elements for interactive behaviours. Unlabelled images can't be understood as buttons by assistive tech.

  I'd also recommend you include one of the content blacks as a Default. Search engines need there to be content, and it's best practice to include fallback content in case js doesn't load or is turned off.

  I hope these tips make sense and are helpful

  0