Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- The
width: 1440px
property for.main-app
element is not necessary and it may cause overflow issues on smaller devices with smaller screens. it's a block level element also so it will take the full width of the page by default.
- Use
min-height: 100vh
for.main-app
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then the.main-app
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then the.main-app
will start at100vh
, if the content pushes the.main-app
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
0
stefanappdev• 150
@stefanappdev
Posted
@0xAbdulKhalid thanks much appreciated
0