@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Replace height with min-height in your .parent to fix background issues and use flex or grid to properly center the card don't use margin or padding for the same.
➨ Remove paddings from the .parent as this will not dynamically center the card .
➨ To properly center the container.
- USING FLEXBOX
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
- USING GRID
body{
min-height: 100vh;
display: grid;
place-items: center;
}
➨ Use Semantics for the proper design of your code.
<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribtution` div inside your footer.
</body>
-
Every site must have one
h1 elementdescribing the main content of the page. -
So, Add a
level-one headinginstead ofptoimprove accessibility. -
<h1>Gabrielle Essence Eau De Parfum</h1> -
It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture>
<source media="(min-width:800px)" srcset="yourimage.jpg">
<img src="yourimage.jpg" alt="description">
</picture>
-
For
non-decorative imagesgive meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves.". -
Use
responsive units(rem, em, %)from next project. Explore respective use cases on google. -
Replace
widthwithmax-widthto make your card more responsive.
link.
I hope you find this helpful.
Happy coding😄
Marked as helpful
