Responsive design done with plain html, css, javascript.

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Adam Phillips! 👋

  Well done on this challenge! 👍 Your solution looks pretty good and the slider works well! 🙌

  I small suggestion I might make is to decrease the height of the background shape to match that of the original design a little more (it covers the full height of the page in your solution, at the moment).

  Also, something small you can do to avoid having to create a div simply to add those checkmark icons is to use pseudo-elements to add those icons (which you can do by setting the content property to a url() to the checkmark icons). You can then position them relative to the labels next to the checkmarks using absolute positioning. 😉

  Keep coding (and happy coding, too)! 😁

  1
• 

  Batool H.•320

  @BatoolHasanPosted almost 4 years ago

  Thank you for your submission! I learned a lot from it, especially the trick to the background of the slider.

  Some improvements would be to decrease the headings font size on the smallest version, and note that in the smallest version the heading 'Sign-up for our 30-day trial. No credit card required.' actually ends up separating the two sentences over two lines.

  One other improvement would be to remove the default border CSS applies to button elements. As for the input type of range, make sure to add a title attribute to fix the accessibility issue.

  1

  ---

  

  Adam Phillips•115

  @adphillips2017Posted almost 4 years ago

  Thank you for the feedback. Those are all very good points. I am going to go back and make changes to my project later.

  1

  

  Pharmack•320

  @Pharm-ackPosted almost 4 years ago

  @adphillips2017 you did a great job. Besides how can I contact you privately, I need help with the same project?

  0

  

  Pharmack•320

  @Pharm-ackPosted almost 4 years ago

  @adphillips2017 sent you a request

  0