Responsive design, CSS Flexbox

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @sinemcetin94 , adding to what was said above/below:

  • For this challenge you want to use the Image Element not the Background Image Property. The Background Image Property is mainly used on decorative images NOT images that add value and serve a purpose. Like in this challenge, where the image has to be scanned.

  • Once the image implementation is corrected, you want to include an Alt Tag description . The description needs to tell screen reader users what it is and where it will take them to when they scan it.

  • To make your QR image responsive delete the height and add the following to it:

  .card__image {
     max-inline-size: 100%;
    block-size: auto;
  }
  

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Sinem•80

  @sinemcetin94Posted about 2 years ago

  @vcarames thank you for your help :)

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @sinemcetin94, congratulations on your solution!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Sinem•80

  @sinemcetin94Posted about 2 years ago

  @correlucas thanks a lot for your recommends. I have learned new things :)

  0