Responsive design and mobile first

Community feedback

• 

  Juveria Dalvi•1,375

  @Juveria-DalviPosted about 3 years ago

  hey.. the accessibility issue says that you should have wrapped all divs in <main> which is the semantic tag ,except for the div with class attribution that should be wrapper in <footer> tag also <img> tag should have <img src="....." alt="yourtext">

  Marked as helpful

  0

  ---

  

  Alejandro Villaescusa•190

  @alexvillhenPosted about 3 years ago

  @juuveria I totally forgot about that div when i uploaded it, thkssss😅

  0
• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hello, nice work and responsive too.

  I would like to add some suggestions,

  • try to use background-image since in design it is named as bg and they are more likely to treat as background images, and change background with media-query.
  • Your images should have alt attribute but for decorative images, you should leave alt as blank and use role=" presentation" or aria-hidden=" true", In your case illustration and music-icon both behave as decoration.
  • change should behave as it controls something, and for controlling prefer button and proceed to payment implies navigation so should probably be anchor tags.
  • Active-states on change and cancel will make your solution more attractive, so add them too.

  Aside from those, really great work.

  0

  ---

  

  Alejandro Villaescusa•190

  @alexvillhenPosted about 3 years ago

  @muhammadshajjar ohhhh thkssss, your comment is really helpful, i'll consider those things on my next projects 😁

  0