RESPONSIVE DARK LANDING PAGE + FLEXBOX

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  There is still some work to be done :

  • the display is generally not pleasing to me with the exception of the desktop which looks a bit better. The mobile , medium devices up to about 1300px - a lot has to be done to make it responsive. At 375 might seem better as well but there is a lot of scrolling to the right.
  • while using more than one h1 elements does not cause errors , it is not considered as best practice as it is not beneficial to screen readers
  • the links in the footer has to be links which are in an unordered list not p elements.
  • i am not a fan of desktop first - so maybe i might not be helpful to the question on responsiveness as you are using desktop first. The benefit of using mobile first is that you can write less code. Your base code will cater for small / mobile devices and then you only apply media queries when your code starts to break. Something that you might have to use when the screen size reaches about 600px. The break point will be using min-width .
  • also with this design one break point might not be enough.
  • i would encourage you to look at conquering responsive layout and do a less challenging project first

  Marked as helpful

  1
• 

  Gargi Thakare•5

  @gargithakarePosted over 3 years ago

  Honestly, I liked yours more than the actual solution. You have larger text which I think is easy to read for the users. Very satisfying to the eyes.

  1

  ---

  

  Paras Sharma•700

  @imparassharmaPosted over 3 years ago

  @gargithakare thanks for the appreciation. Means a lot to me.

  0

  

  Gargi Thakare•5

  @gargithakarePosted over 3 years ago

  @imparassharma btw can you help me in something? I am having trouble getting the URL of my live site because of which I'm not able to upload my challenge here. its my first challenge.

  0

  

  Paras Sharma•700

  @imparassharmaPosted over 3 years ago

  @gargithakare After uploading the code in github go in code section where your files are placed. Above the Add file there will be a setting icon you just have to select it and look for pages in that menu. After going in the pages option select the branch to main branch and save. The github will provide you a link which will be accessible after few minutes. Hope it will work for you!

  0