P
Stefan Vetsch• 100
@vstm
Posted
Nicely done, congratulations on finishing your first challenge :D
I think your HTML looks really clean, I also like the comments in your CSS (comments are something I should use more often).
Here are some things I think you could improve:
- I think the line
<link rel="stylesheet" href="Outfit.zip">can be removed, since stylesheets should be CSS files directly, the browser doesn't know what to do with a ZIP in this context - The line
<link href='https://fonts.googleapis.com/css?family=Outfit' rel='stylesheet'>can be moved inside the<head>tag. The browser handles it correctly but if you check out the DOM in the inspector that is because the browser moves it automatically inside the<head>tag. <img id="qr" ...-> I would change thatidattribute toclassand use a class selector in your css (#qr->.qr). This way your "way of styling" is consistent (all the other elements you also style with class selectors). Also depending on who you ask ID selectors are discouraged because they are not reusable. For example and you can only style one element per page with it, because only one element can haveid="qr".
I hope my comment helps you, if you have any questions regarding my feedback don't hesitate to ask me :D
0
Eucalyptus2• 10
@Eucalyptus2
Posted
@vstm Thank you so much! I will apply :)
0
