Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive CSS Grid a11y

P
Sam Hooker 410

@35degrees

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am improving my use of semantic HTML and adding roles for accessibility. I am understanding better how tab-indexing works and including it in my functionality. I feel like I leveled up on this project and I'm getting faster and more confident in my coding.

What challenges did you encounter, and how did you overcome them?

Lightbox was a challenge to add to the finished site, fun to learn. Lots of JS tricks implemented and a lot of media changes in the mobile version.

What specific areas of your project would you like help with?

a11y and ARIA headers.

Community feedback

P
Dan Marius 625

@danmlarsen

Posted

Hello there. Congratulations on finishing another challenge! Your solution responds quite well and looks nice 👏

I've made one accessibility observation that might interest you:

  • When I hover one of the thumbnails the main image seems to be removed, which is somewhat confusing. I think the problem is somwhere in the updateMainPhoto function. All image urls seems to go to: "https://github.com/35degrees/ecommerce-landing-a11y-fem20/blob/main/images/image-pro"

Happy coding. 💻

Dan

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord