Design comparison
Solution retrospective
Thank you all, guys for your comments and advices!
Community feedback
- @akshay63Posted over 3 years ago
Hey, Viacheslav! Even if you have done some mistakes, you have done a great job in creating the site for the desktop. Don't bother much rather revise the concepts of basic layout methods using CSS and apply those to your project.
Some changes I suggest you try out: 1.To answer your first question: We have to only change the font size of the overall font in the HTML element itself only and not to both HTML and Body element. 2.To change the background-image size: set the 'background-size: cover' for the image and do not use the object-fit property for images because it is for background videos.
I also have done some changes to your code if you don't mind.
0@vstrogalevPosted over 3 years ago@akshay63 thank you a lot! I have deleted font-size in Body tag, and set image as background image so I deleted srcset in html that is better.
0@akshay63Posted over 3 years ago@vstrogalev Great. Now you can work on adding other Media queries for tablet (portrait/landscape) viewports. Just don't overwhelm yourself. Keep coding!π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord