Skip to content
Submitted over 1 year ago

Responsive Css

kareem bakarbashat•20
@Kareem-kb
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Jacksen•350
    @jacksen30Posted over 1 year ago

    @Kareem-kb awesome job ! I've just completed this project myself.

    A few easy to implement suggestions would be...

    HTML

    The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can just update it to a <h2> (for example) later if you need to use more heading in your html code.

    <main>

    Wrap the page's whole main content in the <main> tag (everything inside <body> that's exclusive to that page so make sure <header> <footer> and sidebars are not wrapped for example)

    border-radius

    Also on the your div class="wrapper" might require the same border-radius on the right hand side as you gave your img so that all corners are the same radius, for example (change 10px to what ever you used on the img border)

    .wrapper {
   border-radius: 0px 10px 10px 0px;
  }

    I hope this will help, If you have any related questions let me know and I'll do my best to help.

    Look forward to following your journey ! Happy <coding>

    0
  • Finney•3,030
    @Finney06Posted over 1 year ago

    Hello there 👋. Good job on completing the challenge !

    Here are some suggestions regarding your code that may be of interest to you.

    HTML 🏷️:

    To clear the Accessibility report:

    • Images should have alternate text. <img src="images/icon-memory.svg" alt="memory icon"> this provides alternative text descriptions of images for people who are visually impaired and rely on screen readers to navigate the web. Screen readers can read the alt text aloud, enabling these users to understand what the image represents and how it relates to the content on the page. Overall, including alt text in HTML is an important best practice for creating accessible and user-friendly web content.

    • Wrap the page's whole main content in the <main> tag.

    • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

    I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord