Responsive country-render page, HTML5, CSS3, Vanilla JS.

Community feedback

• 

  Alex•330

  @CallMe-ALPosted over 2 years ago

  I like your different takes on the site style-wise! The modal especially is a nice touch. I like the image showing no country has been found and emojis next to certain info, too. Some suggestions:

  -Adding a transition when toggling between light/dark modes can help make the change feel more smooth. -I can search for white space in the search bar -- using the .trim() method on your search input can help prevent this issue. -Try adding some styling to let users know clicking on a border region will take them to that region. -Check over your report for some minor accessibility issues.

  Overall great job, again love the changes. As an additional challenge maybe try displaying regions conditionally based on search input while the user types (hint: the .filter() method can be helpful here!). Keep it up, man!

  Marked as helpful

  1

  ---

  

  omared250•150

  @Omared250Posted over 2 years ago

  Hi @CallMe-AL,

  Thanks for the feedback I really appreciate it, I will work on improving the aspects of the project that you tell me, again thank you very much.

  1
• 

  P

  Curtis•930

  @webguy83Posted over 2 years ago

  There are a few issues here:

  I tried filtering any country and it's broken and doesn't yield any results even if I type in a country correctly. When I am on the broken results screen and in dark mode it doesn't extend all the way to the bottom of my screen. When you are at the broken screen there is no way of getting back the countries unless you use the Regions dropdown and manually load in more

  Header bar should extend the full width of the users screen accroding to the mockup. Font size is off on the header text Since you load your api call with all the countries at the beginning of the app there shouldn't be a need for further api calls when you filter the region (big performance implications) You have JavaScript errors in our console Look at Macau and you see it has a capital of undefined

  These here are my opinions: Having a modal screen you have to be careful with them. They generally work with as little data as possible but if you look at the requirements for this project it has a lot more data to be shown which would be too much for the modal to handle and in this case it makes sense to have a details page. The buttons also in your modal for the Border Countries don't really look like buttons at all, just simple text.

  Also look into the report with the accessbility and html issues too. Hope it helps!

  0