Responsive country search website using html, scss and javascript

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Ronel, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • add main tag and wrap the content of page for improve the Accessibility
  • add descriptive text in the alt attribute of the images of flags
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of flag images or div container of title of cards
  • use h2 or h3 tag for the title text of country and not a p
  • use ul element for the details text of country instead of multiple p
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"

  Hope this help! Happy coding 😁

  Marked as helpful

  0

  ---

  

  Ronel Florida•450

  @Ronel028Posted over 2 years ago

  @denielden Thank you so much for the tips

  1