Responsive countries app with dark mode using React

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Mariano, You have done a good work! 😁

  Some little tips to improve your code:

  • remove max-width: 1440px from #root id
  • add header tag and wrap the navbar for improve the Accessibility
  • add main tag and wrap the main page content for improve the Accessibility
  • use article tag instead of a simple div to the container cards of country for improve the Accessibility
  • instead of using px use relative units of measurement like rem -> read here
  • use ul element for the details text of country instead of multiple div
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  0