Responsive contact form

Community feedback

• 

  Ibrahim Morad•380

  @IbrahimMuradPosted 16 days ago

  Looks good. But you need some adjustments for better results.

  1. Add novalidation to the form since you are validating manually.
  2. Remove the action attribute; you are not making any requests.
  3. The event listener should be 'submit' on the form, not the 'click' on the button.
  4. aria-descripedby takes the id of the error element; you passed the id of the same element.
  5. Since you added required to the inputs, you just need to use inputElement.validity.valid to check if the value is valid (in this case, it will ensure that the value is provided and the email is a valid email).
  6. Give each label for the radio input a unique for value (for example, the value itself - general or support-), then add an id with the same value so that when you click on it, the value is selected.
  7. I noticed that you, sometimes, uses <br />, it works but you can wrap the elements that you want in the same line and use CSS to style it to stay in the same line, and also with CSS make sure the next element is in its own line.
  8. some other styles are missing, but I think its fine.

  Let me know if you need more clarifications.

  1
• 

  Ilham Bouktir•420

  @ilham-boukPosted 12 days ago

  Good solution for this challenge.

  0