Design comparison
Solution retrospective
Hello
I used:
- React (typescript)
- Chart.js (Bar chart)
- scss
- bem methodology
I'am open to any suggestions :)
Community feedback
- @ApplePieGiraffePosted over 2 years ago
Hi, Paweł Ciszewski! 👋
Good job on this challenge! 👏 Your solution looks great and I really like the animation that you added to the bar chart! 🙌
One thing I'd like to suggest is to specify values such as `margin`, `padding`, `font-size`, and more in a responsive unit such as `em` or `rem` (not `px`, which is a fixed unit), to ensure that changing the font-size of the document causes the rest of the site to scale up/down (which is important for accessibility reasons). To learn more about `em` and `rem`, see this helpful article.
Hope that helps. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful1@kardahimPosted over 2 years ago@ApplePieGiraffe Oh thank you, this is so helpful advice.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord