Responsive component using CSS flexbox

Community feedback

• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 8 months ago

  Hey Nikhilsuthar, I liked your project and decided to take a look at it for a bit, and I found some things I think you can improve on.

  1. I would change the class name of textbox to a more conventional text-container

  2. I would remove the section tag, add height of 100% to html and body tags, then give display of flex to body instead of section, and card should be a tag of main because thats where the main content is

  3. Use CSS variables, they are a powerful tool to help make your code more readable and easy to manipulate,

  4. Add alt text to your img tag, it is never good for it to be empty, it is used to desribe what the image is off for people that have images turned off, or in case the image doesnt load properly, it is also very helpful for SEO

  5. The solution you provide should match the design, it is a bit complicated to understand how to do that for the first time, so if you want, I have written my own blog post on solving this challenge, where I explain how to make pixel-perfect solutions to the challenge.

  https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-4g9h

  Overall still one of the better projects I have seen so fat, and I hope these tips help you become a better web developer, and help you on your journey towards getting this amazing job!

  if you have any more questions feel free to let me know, have an amazing day, and happy coding :)

  0

  ---

  

  Nikhilsuthar09•70

  @Nikhilsuthar09Posted 8 months ago

  Hello @DanijelAdrinek thankyou so much for your valuable feedback, will surely be considering the SEO part from my next project onwards and other suggestions that you mentioned. Have a great day :)

  1