@5hraddha
Posted
Hi @sisodiaa, Congrats on completing the challenge and doing a great job at implementing the design. I appreciate your clean indented code writing style. 👍
There are a few things that I want to suggest in case you want to look for further improvements (either in this challenge or the next):
-
Instead of using
<div>
tags as a container everytime, you could look into using different HTML semantic tags. It gives better meaning to the markup and improves accessibility. Freecodecamp Semantic Elements -
Since, you have used BEM naming convention for CSS class names, you could also divide and modularize your css file into several smaller files and arrange them according to BEM File Structure Organization Methodologies. This would be beneficial for large projects especially. You could look into this link - BEM File Structure
Marked as helpful