@shashreesamuel
Posted
Good job Piotr
Keep up the good work
It appears that you forgot to include the header image for the card
In terms of your design aspect I have some suggestions
-
The card is missing a subtle box-shadow using
box-shadow
-
The path to your music icon is incorrect and supposed to be
./images/icon-music.svg
-
The "Proceed to Payment" button needs some margin from the bottom using
margin-bottom
-
The background on the body element is supposed to be a light blue.
In terms of your question regarding, I think you should use percentages since it is relative to the device screen size. Pixels and vw
is just going to constraint the specific element.
Let's talk about your accessibility issues
-
Document should have one main landmark, this is caused by your document unable to identify the main content and can be fixed by using the semantic main tag which when enclosed with elements located within the body element will indicate that a main content exists
-
Page should contain a level-one heading, this is caused by not having a
h1
tag within your document.
I hope this helps
Cheers
Marked as helpful