Aman Singh Bhogal• 1,010
@asbhogal
Posted
Hi Victoria,
This is great work, well done! The design matches the mockups nicely and the validation seems to function well too. Just a few things I've noticed which are worth considering when refactoring:
- It's best to use npm packages for your Tailwind instead of a CDN, as this isn't optimized for production (the CDN is designed for in-browser development using online sandboxing tools.) Using the
npm
version means your build is optimized, compressed and minified and you can also customize your configuration (more on this below) Here's a link to some documentation on how to get this up and running Link I recommend using Vite to handle the compiling of the Tailwind utility classes into standard css. If you're unfamiliar with this, I've also added a link here on how to handle this. Link - You should locally host your Google Fonts. With
npm
environments, you can install the typeface through the Fontsource dependency, then import the weights you need and reference them in yourtailwind.config.js
file (either by extending or overriding the theme.) I've added some links below regarding this - Your image is compressed between
1000px
and768px
, it might be worth reviewing and changing the breakpoint classes for when the content flows vertically - I can see you've referenced both the images for mobile and desktop, however I can't confirm whether they change respective to the viewpoint. You should ideally have these within a
<picture>
tag which achieves this by specifying the width for the mobile version, for e.g., to display. Here's a link to an MDN article explaining this in further detail Link
Hope this helps!
Marked as helpful
0